chore(helm): route default targets eagle-admin - #943
Merged
Merged
Conversation
rproxy is retired. Dev/test Routes now go straight to the eagle-admin service by default.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
September 17, 2026 04:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rproxy is retired. Dev and test Routes go straight to the eagle-admin Service, so the chart default should say so instead of relying on per-env overrides.
values.yaml:route.serviceNamedefaulteagle-admin(template previously fell back torproxy).values-dev.yaml,values-test.yaml: drop the explicitserviceName, now the default.values-prod.yamlunchanged. Prod renders no chart Route.Rendered Route for dev and test: host per env,
path: /admin/, serviceeagle-admin, port8080-tcp. Theeagle-admin-directRoute renders unchanged.