fix(tables): make headers sort buttons with aria-sort - #945
Merged
Merged
Conversation
- Column sort resets to page 1; keyword search keeps the sort - Deleting the last rows on the last page steps back one page - Days Remaining is not sortable (computed, not a stored field) - Group contacts keep page and pageSize - Mark multi-key sort columns
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
September 24, 2026 21:51
danieltruong
added a commit
that referenced
this pull request
Sep 24, 2026
danieltruong
added a commit
that referenced
this pull request
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sorting across the admin tables.
aria-sortand shows an arrow for the active sort. For a sort on several fields, the header of the first field shows it. A column whose own value is a multi-field sort, such as Contacts Name (lastName,+firstName), is marked too.Tests: new specs for the table template, the sort helper, activity, comment periods, project documents, group contacts and search.