Skip to content

fix: Admin roles modules empty config - #1495

Merged
didoda merged 2 commits into
bedita:masterfrom
didoda:fix/6.x/admin-roles-modules-empty-config
Oct 14, 2026
Merged

didoda merged 2 commits into
bedita:masterfrom
didoda:fix/6.x/admin-roles-modules-empty-config

Conversation

@didoda

@didoda didoda commented Oct 14, 2026

Copy link
Copy Markdown
Member

This provides an update in Admin -> Roles Modules page, by handling cases:

  • no roles available
  • no modules available (a non admin authorized to "/auth" endpoint for "manager" app)
  • no config has ever been saved
  • first time save
  • delete a config

@didoda didoda added this to the 6.x milestone Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (b8a258a) to head (df18999).
⚠️ Report is 33 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1495   +/-   ##
=========================================
  Coverage     99.62%   99.62%           
- Complexity     1567     1572    +5     
=========================================
  Files           105      105           
  Lines          6077     6095   +18     
=========================================
+ Hits           6054     6072   +18     
  Misses           23       23           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didoda
didoda merged commit 4381c1d into bedita:master Oct 14, 2026
13 checks passed
@didoda
didoda deleted the fix/6.x/admin-roles-modules-empty-config branch October 14, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant