Repository navigation
Conversation
Category picker (index filter and bulk action) shows parent categories as groups with their children; only children and root categories without children can be selected. Categories tree logic shared with object categories form.
nikazzio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Categories picker (index filter and bulk categories action) listed all categories flat: parents and children mixed at the same level, and parent categories with children were selectable even though objects can't be assigned to them from the Manager (filtering by them returns no results).
Changes
category-picker: options built as a tree. Root categories with children are groups (not selectable), only enabled children and enabled root categories without children can be selected. Groups with no enabled children are hidden. Sorted by label, name when label is empty.app/helpers/categories.jswithcategoriesTree()andcompareCategories(): two levels tree grouping and sorting, shared bycategory-pickerandobject-categories(removes duplicated tree building and sort logic fromobject-categories).object-categories: same rendering as before; groups count used to open all groups now counts actual groups (previously included an extra key for root categories).30rem), so long labels are readable without widening the control.