Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documentation contains contradictory Git prerequisites, inconsistent render-pack filenames, and a grammatical error.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (4)
What changed in this PR
Improves documentation tooling, light-theme accessibility, and CLI/package-manager setup guidance.
Changes:
- Adds synchronized npm, Yarn, and pnpm command tabs.
- Introduces text-safe category/status colors and accessibility styling.
- Updates CLI, installation, render-pack, and CI documentation.
| File | Description |
|---|---|
src/theme/MDXComponents.tsx |
Registers PackageCommands. |
src/data/sections.ts |
Adds category text color tokens. |
src/css/bedrock/infima-bridge.css |
Improves light-theme accessibility. |
src/css/bedrock/colors.css |
Adds text-safe color aliases. |
src/components/PackageManager.tsx |
Supports configurable command languages and variants. |
src/components/PackageGrid/index.tsx |
Applies text-safe category colors. |
src/components/Home/home.module.css |
Adjusts light-theme step colors. |
src/components/ds/index.tsx |
Adds text-safe card accents. |
src/components/ds/ds.module.css |
Uses accessible warning and CTA colors. |
docs/ui/installation.md |
Updates prerequisites and render-pack dependency. |
docs/ui/guides/render-pack.md |
Documents versioned render-pack names. |
docs/server/installation.md |
Updates prerequisites and imports. |
docs/filters/ci.md |
Adds package-manager CI workflows. |
docs/cli/index.md |
Documents package-manager setup and CLI output. |
.gitignore |
Ignores review artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ### GameTests | ||
|
|
||
| `packs/BP/scripts/tests/index.ts` registers one GameTest tagged `example` through `@minecraft/server-gametest`, a beta module only `manifest.test.json` declares. `gametest.ts` — the entry `tsconfig.test.json` names — imports `./main` then `./tests`, so a release build (`main.ts`) never pulls in the test suite or the beta module. `yarn build:test` produces the pack [`bds-runner`](/docs/bds-runner) runs the suite against. | ||
| `packs/BP/scripts/tests/index.ts` registers one GameTest tagged `example` through `@minecraft/server-gametest`, a beta module only `manifest.test.json` declares. `gametest.ts` — the entry `tsconfig.test.json` names — imports `./main` then `./tests`, so a release build (`main.ts`) never pulls in the test suite or the beta module. The `build:test` script produces the pack [`bds-runner`](/docs/bds-runner) runs the suite against. |
|
|
||
| - Node.js 20+ and Yarn (or npm) — https://nodejs.org/ | ||
| - Regolith (recommended) — https://regolith-docs.readthedocs.io/en/stable | ||
| - Node.js 22.18+ and Git — [https://nodejs.org/](https://nodejs.org/) |
| ## Getting the matching pack | ||
|
|
||
| The render pack ships as the `core-ui-v*.mcpack` attached to each `@bedrock-core/ui` release, and the [CLI](/docs/cli) downloads the latest one into new projects automatically. **Take the pack from the same release as the library** — that pairing is the compatibility contract. | ||
| The render pack ships as `core-ui-<UI version>.mcpack`, attached to the matching `@bedrock-core/ui` release. For example, UI `0.12.1` uses `core-ui-0.12.1.mcpack`. The [CLI](/docs/cli) downloads that matching asset into new projects. **Take the pack from the same release as the library** — that pairing is the compatibility contract. |
|
|
||
| - Node.js 22.18.0+ and Yarn or npm — https://nodejs.org | ||
| - Regolith — https://regolith-docs.readthedocs.io/en/stable | ||
| - Node.js 22.18+ and Git — [https://nodejs.org/](https://nodejs.org/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.