fix(release): handle root package tag separately - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The release flow is functionally correct and rerunnable; only a non-blocking documentation inconsistency remains.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR separates root-package tagging and GitHub release creation from Changesets Action while preserving child-workspace reporting.
Changes:
- Excludes the root package from
CHANGESETS_OUTPUT. - Adds an idempotent root tag/release script using changelog notes.
- Runs root release handling after the Changesets publish action.
| File | Description |
|---|---|
scripts/tag-packages.mjs |
Reports only child workspace tags. |
scripts/release-root-package.mjs |
Creates the root tag and GitHub release safely. |
.github/workflows/publish.yml |
Invokes root release handling with GH_TOKEN. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+55
to
+58
| // Changesets Action's package map contains child workspaces only. The root | ||
| // meta package is pushed and released by release-root-package.mjs after the | ||
| // action has handled the child packages. | ||
| if (process.env.CHANGESETS_OUTPUT && workspace.location !== '.') { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm packages published successfully, but Changesets Action v2 failed before pushing tags or creating releases because its package map excludes the workspace-root
@bedrock-core/serverpackage.This reports only child workspaces through
CHANGESETS_OUTPUTand adds a rerunnable step for the root meta-package tag and GitHub release. The root release uses the matching changelog entry and safely skips an existing tag or release.Validation:
node --checkfor both release scriptsgit diff --check