Skip to content

feat: add zizmor to pre commit and fix flagged errors - #818

Merged
freakboy3742 merged 6 commits into
beeware:mainfrom
Ashton321:main
Aug 30, 2026
Merged

freakboy3742 merged 6 commits into
beeware:mainfrom
Ashton321:main

Conversation

@Ashton321

@Ashton321 Ashton321 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor
  • Added zizmor to the pre commit config and ran precommit. Fixed all flagged issues that zizmor raised, including permissions not being set, persistent credentials being saved and unpinned-uses issues.

Fixes #805

PR Checklist:

  • I will abide by the BeeWare Code of Conduct
  • I have read and have followed the CONTRIBUTING.md file
  • This PR was generated or assisted using an AI tool
    Assisted-by: github copilot (GPT-5.4-mini)

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of mostly cosmetic cleanups, and this should be good to land.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/zizmor.yml
… file content same as others, remove unneeded permissions

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor code formatting cleanups, and this should be good to land.

Comment thread .github/workflows/new-issue.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/translate.yml Outdated
Comment thread .github/workflows/translate.yml Outdated
Comment thread .github/workflows/ci.yml
@freakboy3742
freakboy3742 merged commit 68d7f7b into beeware:main Aug 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add zizmor pre-commit configuration

2 participants