Repository navigation
Render LaTeX formulas again; opaque study tool lists; 0.16.5 - #20
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ihz5z81AZ27T33PMCKkaL
Formulas showed as raw `$$…$$` source everywhere (notes, study tools, Ask AI). MarkdownView compiles its LaTeX support and links SwiftMath only when its `LaTeX` trait is on, and an Xcode project does not pass package traits before Xcode 26.4, so CI (Xcode 26.2) built every release without it. MarkdownView now comes in through a local package, Packages/MarkdownRendering, whose manifest asks for the trait. A CI step fails the build if the flag or SwiftMath's resources are missing. The study tool, highlight and note version lists used the sidebar list style, which brings the window sidebar's translucent material into the page. They use the opaque inset style now. Version 0.16.5 (build 23). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ihz5z81AZ27T33PMCKkaL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formulas showed as raw
$$…$$sourceEvery formula, in notes, study tools and Ask AI alike, came out as its LaTeX source. Math detection itself is fine: running MarkdownView 3.0.0's preprocessing and parser on the exact text from the bug (in full and streamed token by token) finds and replaces every formula. The problem was that the math code was never compiled in.
MarkdownView defines
ENABLE_MATH_RENDERINGand links SwiftMath only when itsLaTeXpackage trait is on. The trait is on by default, but Xcode projects don't pass package traits before Xcode 26.4, and CI and release builds use Xcode 26.2 (the macos-15 runner has nothing newer than 26.3). So every build so far had LaTeX compiled out. The CI log confirms it: 0 mentions ofENABLE_MATH_RENDERING, and noSwiftMath_SwiftMath.bundlein ClassNote.app, even though MarkdownView's other dependency, Highlightr, was there.Fix: MarkdownView now comes in through a local package,
Packages/MarkdownRendering. Its manifest asks for the trait (traits: ["LaTeX"]) and re-exports MarkdownView. SwiftPM honours a trait requested in a package manifest whatever the Xcode version. With this change, CI on Xcode 26.2 builds with the flag and bundles SwiftMath.Guard: a new CI step, "Check LaTeX rendering is compiled in", fails the build if either the flag or SwiftMath's resources are missing. It failed on the current main code and passes with this change. The release workflow runs CI first, so a release can't ship without math again.
Opaque study tool lists
The study tool list, the highlight list and the note version list used
.listStyle(.sidebar). That style brings the window sidebar's translucent material into the page, so the desktop showed through. They now usepaneListStyle()(the opaque inset style). The main window's real sidebar keeps its normal translucent macOS look.Version
0.16.5 (build 23), ready for the
v0.16.5tag.🤖 Generated with Claude Code
https://claude.ai/code/session_015ihz5z81AZ27T33PMCKkaL
Generated by Claude Code