fix(rollout): skip process cleanup for Oracle - #1085
Open
zhiheng-yang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(rollout): skip process cleanup for Oracle
Summary
Oracle mode awaits
solve.shdirectly and does not start an ACP or session agent.Rollout.disconnect()nevertheless treated the fallback launch labeloracleas a process name and derived this cleanup command:There is no persistent Oracle process for that pattern to clean up. On a runtime that shares the runner's PID namespace, it can instead match BenchFlow's own
--agent oraclecommand and terminate the run after verification but before the final result is built.This change skips pattern-based cleanup only when the current launch value is exactly
oracle. Other agents, including similarly named launches such asoracle-agent-acp, keep the existing cleanup behavior. The check uses the current_agent_launch, so role changes throughconnect_as()remain aligned with the process that was actually launched.Testing
oracle,opencode, and theoracle-agent-acpnear-match; the regression fails onmainand passes with this change.286 passed. Ruff, changed-file formatting, andty checkalso pass.1/1 passed, mean reward 1.00, errors=0, with the final summary and artifacts written successfully.