Repository navigation
fix(cli): complete short output writes - #1691
Merged
Lorenzobattistela merged 2 commits intoOct 19, 2026
Merged
Conversation
toprameen
marked this pull request as ready for review
October 18, 2026 00:36
Lorenzobattistela
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI output could end successfully after a short write to a nonblocking pipe.
The writer now encodes each message once and continues from the last byte
written until the output is complete. Temporary write errors are retried,
zero progress fails, and closed readers leave the command's exit status intact.
The new compiled-CLI test sends Unicode guide text through a real nonblocking
pipe and restores the guide afterward.
The regression fails on the baseline and passes with the fix in source and
compiled CLIs on macOS and Linux arm64. Local retry and closed-reader checks
pass, as does the repository gate (54/54). Strict TypeScript retains the same
11 baseline diagnostics.