Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C path casts to u32 before converting. Do the same before Math.fround on JS, so a host value of -0 cannot introduce a floating-point sign into an unsigned zero. Integer marshalling and genuine F32 negative-zero inputs stay unchanged.
The regression feeds zero through real typed U32/F32 host answers on both lanes. Before: JS prints 2147483648 for the converted U32, C prints 0. After: both print 0; the F32 negative-zero control still prints 2147483648. Another 4,103 actual exported conversion cases passed, including full-range boundaries. Repository gate: 54/54 with existing caps. No parser, kernel or CHANGELOG edits.
Fixes #1692.