Run post-upload hook after local validation completes - #3218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing built-in validation from the WebUI previously skipped
post_upload_scriptwhen no publishing provider was configured. The validation completion path now invokes the existing shared hook for local runs, usingoutput_diras{local_checkpoint_path}and an empty remote path, without requiring a checkpoint.This also covers scheduled validation and base-model benchmarks. Configured providers retain their existing per-upload paths and hook behavior; upload failures do not generate an extra local hook. Skipped, failed, aborted, non-main-rank validation and external-script launches do not trigger the hook. Updated option documentation in all six languages and WebUI field help.
Validation: reproduced the missing hook with a failing forced-validation regression before the fix, then passed 41 tests with
.venv/bin/python -m unittest -v -f tests.test_validation_upload_hook tests.test_validation_external tests.test_validation_abort tests.test_validation_audio_mock tests.test_script_runner. Tests mock generation while exercising the real validation completion and script formatting paths. The available environment uses Python 3.14 rather than the documented 3.13.git diff --checkpasses.Fixes #3199.