Fix file metadata escaping and bound key and SMB work - #216
Merged
Merged
Conversation
bifrost0x
marked this pull request as ready for review
September 14, 2026 10:46
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve remote filenames as literal text in file-workspace markup, apply a shared per-user budget to expensive key summaries, and require progress while enumerating SMB directory pages.
SSH_KEY_LIST_RATELIMITdefaults to 30 per minute across sockets and list/rename/replace/delete operations. Mutations reserve their refresh before changing storage. Successful acknowledgements, fresh usability checks, storage-error responses, and user isolation are preserved; there is no key cache or storage-format change.Validation on final commit
e6f00266811dc5c68dab92cf029c1cc8621fc7a9:The initial full browser run exposed shared-account budget contention in two cases. Both passed on a fresh test instance; the browser-only server now has an explicit bounded 100-per-minute budget alongside its existing test login budget. Product defaults remain 30 per minute, and the shared per-user admission/side-effect contracts are tested directly. The full browser suite then passed without retries. Local Docker access was unavailable; live SMB validation was performed successfully in CI.
ARM64 image build/security and the combined image-security gate also passed. All applicable CI checks are green. Image publication is intentionally skipped for pull requests; no merge or deployment has been performed.