Repository navigation
Support Warpgate SSH selectors and interactive authentication - #238
Merged
Merged
Conversation
bifrost0x
marked this pull request as ready for review
September 23, 2026 07:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b97a9b4d9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warpgate connections need selector usernames, explicit multi-factor authentication, and target readiness before WebSSH starts a shell, tmux, or startup commands. This adds
user:targetsupport to existing SSH profiles and Quick SFTP with socket-owned prompts, bounded output, cancellation, and quota admission.The integration is disabled by default. An administrator enables it globally under Settings → Administration → Integrations, using the existing protected settings endpoint and password/factor step-up. The setting persists in the existing application settings store. The server rejects gateway requests while disabled, including requests from stale or modified browser clients. Disabling also blocks unfinished gateway authentication; stored profiles and established sessions are retained. Open workspaces must be reloaded to refresh their UI capability.
Ordinary SSH retains its existing authentication, cancellation, request tracking, banner wait, and timeouts. Ordinary Quick SFTP remains synchronous. Only enabled gateway requests use the additional interaction lifecycle; cross-path request-ID collisions are rejected. Existing profile auth types, Tailscale authorization, jump-host routing, and host-key checks remain in place. Common SFTP failures now expose safe, actionable reasons such as permission denied or a read-only filesystem without returning raw exception details.
No Compose service, dependency, or database migration is added. Gateway dialogs reuse the existing modal structure, form controls and theme colors, with readable approval links, visible focus states and mobile layout. They remain above connection forms and below authentication banners.
See the integration guide for activation and limits. Terminal targets need PTY and exec support; Quick SFTP needs a temporary PTY plus a separate SFTP channel. Tickets and gateway administration are outside this change.
Validation for
15d9802:3568107baseline: command-storage limit behavior, three POSIX entrypoint tests, the PTY shell probe and Linux route lookup. This is not a fully green local suite.Earlier real-protocol evidence remains revision-specific:
47eb6f3was verified through browser TOTP authentication and cancellation against disposable Warpgate 0.29.0 and OpenSSH. Atf4328b4, all 13 reference Warpgate tests passed, plus terminal commands, byte-identical SFTP transfers, tmux reconnect and WebUserApproval. These protocol fixtures were not rerun for the latest settings/UI change. External identity-provider and live Tailscale acceptance remain deployment-specific checks.Refs #237.