perf: accelerate login and theme background loading - #251
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
Login backgrounds appeared noticeably after the rest of the page, and the first theme switch downloaded a 1.2-2.2 MB PNG. Serve full-resolution WebP backgrounds and start the selected authentication background immediately after resolving the saved theme, instead of waiting for window load and an idle callback.
The ten served images total 857 KB instead of 16.88 MB (94.9% less). Original PNGs are retained. WebP encoding is lossy at quality 90 (89 for Arctic), with unchanged 1672 x 941 dimensions.
Cold-cache Chromium measurements at 5 Mbit/s and 40 ms latency, median of three runs:
These measure background downloads, not whole-app responsiveness. The switch measurement isolates the CSS theme assignment; normal settings persistence is covered by browser tests.
Scope and links
image/webpexplicitly for hosts without a correct MIME mapping.Validation
Head:
635be4228a5d8e865926ff653bf9ead45c34e466; base:c0f83a85c3e8ddd3114c528bb57f14c2a6eb764f.test_entrypoint.pycases, the oversized-command shrink case, the Linux PTY directory probe and the Linux Tailscale route lookup. The additional host-MIME regression passed in the focused run.product-captures.spec.jsexpects the Settings content bottom within 1080 px; both unchanged base and candidate report 1141 px. The two additional asset/fallback tests passed separately.Local suites are not entirely green due to these reproduced baseline failures. Cross-browser and live remote-server integration were not revalidated. Hosted checks remain authoritative for this head.
Delivery
Prepared as a draft for review. No merge, deployment or versioned release is included.