fix: harden iterator MRU storage bounds#3
Open
sit-d wants to merge 1 commit into
Open
Conversation
Author
|
Fresh post-guard ad-hoc verification for the current PR state:
Full Windows |
Author
|
Second fresh post-guard ad-hoc verification for the current PR state:
Full Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IteratorMruLoadListso a corrupt on-diskcountis clamped while still unsigned, before converting toint.IteratorMruSaveList(..., count > 0, items == NULL)before the write path can pass a null data pointer tofwrite.Verification
/tmp/hermes-verify-iterator-mru-post-1b33tm6w.pyasserted the new MRU load clamp, absence of the old cast-before-clamp sequence, the positive-count/null-items save guard, and the retainedcount > 0write guard; it also rangit diff --check HEAD~1..HEAD. The verifier exited 0 and was removed.Notes / limitations
iterator_gdi.cmdbuild/runtime verification was not run from this Linux cron environment because the required Windows SDK/User32/GDI toolchain is unavailable.