Skip to content

catch duplicate utxos - #44

Merged
ulrichard merged 2 commits into
bitcoindevkit:mainfrom
AminaBank:feature/duplicate_utxo
Oct 13, 2026
Merged

ulrichard merged 2 commits into
bitcoindevkit:mainfrom
AminaBank:feature/duplicate_utxo

Conversation

@ulrichard

@ulrichard ulrichard commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

I will handle the deprecated sign method in a separate PR if needed. But it looks like in 3.1 the function is not deprecated.

@notmandatory notmandatory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add #[allow(deprecated)] on the Wallet::sign calls so the CI passes.

@ulrichard
ulrichard force-pushed the feature/duplicate_utxo branch from c0d26fb to af19d2a Compare October 5, 2026 13:22
@ulrichard
ulrichard requested a review from notmandatory October 8, 2026 11:51
@ulrichard ulrichard mentioned this pull request Oct 9, 2026

@notmandatory notmandatory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 07a5178

@ulrichard
ulrichard merged commit dc8ec19 into bitcoindevkit:main Oct 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants