Skip to content

Make release creation retryable and generate notes for the actual tag - #24

Merged
Jamie-BitFlight merged 2 commits into
mainfrom
fix/retry-release-finalization
Oct 10, 2026
Merged

Jamie-BitFlight merged 2 commits into
mainfrom
fix/retry-release-finalization

Conversation

@Jamie-BitFlight

@Jamie-BitFlight Jamie-BitFlight commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Why this change is needed

A transient GitHub release-API failure after the atomic tag/main push could not be recovered by rerunning the original job: the stale-main guard correctly rejected the already-published release child. Independent retries must also preserve existing notes and avoid promoting an older release to Latest.

The old independent changelog calculator could also predict a different version from the one actually published. This PR removes it and uses notes generated for the actual tag.

What changes

  • Keep validation, version selection, tested-content checks, and the atomic non-force tag/main push in the guarded tag job.
  • Pass its exact tag and commit to a separate dependent release job. Rerun only that job, or use Re-run failed jobs, to recover without repeating version preparation.
  • Use the GitHub release API through actions/github-script@v8. Paginate releases so draft lookup is complete and matches the exact tag.
  • Leave a published release unchanged. Resume an existing draft by its exact release ID while preserving its body. Create an absent release with generated notes for the actual tag.
  • Use make_latest: legacy on creation and draft publication, allowing GitHub to select Latest by release date and semantic version. API errors remain failures and can be retried.

The only changed file is .github/workflows/create_tag.yml.

Validation

  • Actionlint passed. Seven behavioral cases executed the actual inline script with controlled GitHub API responses in each repository (21 total), covering pagination, draft/published/absent states, exact mutation payloads, and propagated API errors.
  • All checks passed on final PR head 35fba287cc7e23a0541665498896bdfdb797276a; automated review completed without a new finding. Merged as 66f9890730e9be8baa5c2ce726521e16edabcf8d.
  • Main Jira E2E passed using the verified default-branch fixture cache. Coverage: 178 unit tests, 3 packaged Jira scenarios, and native preservation/reuse/no-duplicate assertions. Main check 1; Main check 2 also passed build and committed-bundle parity.
  • Release v1.0.2 was published by the release workflow. Its commit e75f178a71a80a0f885cbaee92ef63998b2d7492 has the tested merge as its sole parent and changes only README/package version metadata; action source, bundle, manifest, and lockfile remain identical.
  • Live release-only retry passed: attempt 2, job 114112290368 logged Release v1.0.2 is already published; nothing to do. The prior tag job was retained. API comparisons confirmed unchanged main/tag references, release ID, complete notes body, title, target, publication/update timestamps, and Latest selection.

The main Jira/release rollout and selective retry verification are complete. To recover a transient release-API failure, rerun only the release job or use Re-run failed jobs; the successful tag job supplies the original validated outputs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T02:34:21.315333Z 35fba28 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c051ae4f-30bf-4856-be96-dbe9fc1dcffc

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jamie-BitFlight
Jamie-BitFlight merged commit 66f9890 into main Oct 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant