Skip to content

Restrict cleanup to an explicitly identified test release - #31

Merged
Jamie-BitFlight merged 5 commits into
mainfrom
fix/exact-test-release-cleanup
Oct 11, 2026
Merged

Jamie-BitFlight merged 5 commits into
mainfrom
fix/exact-test-release-cleanup

Conversation

@Jamie-BitFlight

@Jamie-BitFlight Jamie-BitFlight commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The existing cleanup runs on PR closure and branch deletion, passes broad regex/PR matching to a mutable third-party action, and can remove releases unrelated to a controlled publication test. Find Issue Keys additionally deletes workflow history older than seven days.

Replace this with an explicit manual cleanup: require the exact vMAJOR.MINOR.PATCH-repair.RUN.ATTEMPT tag and full expected commit SHA, resolve its commit, verify that the exact release is a prerelease, then delete only that release ID and tag ref. Preserve production releases and all workflow history. Use the existing GitHub API mechanism through actions/github-script; no additional dependency or custom helper is introduced.

Local behavioral verification executes the actual workflow script against a recording API fixture: valid test release deletes exactly one release and tag; production tag, regex input, malformed SHA, mismatched target and stable release all fail before any deletion (6 cases pass). Real controlled-publication cleanup and current-head CI remain to be verified. No production tags or releases were deleted.

Verified completion: latest applicable head passed unit/build/lint and real Jira E2E. Controlled publication run https://github.com/bitflight-devops/github-action-jira-issues-fixversion-manager/actions/runs/38099105448 created an isolated prerelease, uploaded and byte-compared the packaged archive, invoked exact cleanup and verified both tag and release absent. The actual cleanup script also passed 11 local behavioral cases, including partial retries and failure propagation. Merged; subsequent release verification work checks the published main commit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T00:32:36.120506Z df13c52 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 383ca0a9-a2cf-45c3-a0aa-250a36185080

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd081cb0ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/pull_request_cleanup_tags_and_releases.yml Outdated
Comment thread .github/workflows/pull_request_cleanup_tags_and_releases.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df13c52b89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/test-release-publication.yml
@Jamie-BitFlight
Jamie-BitFlight merged commit 59bb4db into main Oct 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant