Repository navigation
fix(ci): use normal pushes for dependency bundle updates - #34
Jamie-BitFlight wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef9fc01654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| git add -- dist | ||
| git commit -m 'chore: rebuild packaged action for dependency update' | ||
| git push origin "HEAD:refs/heads/$BRANCH" --force-with-lease="refs/heads/$BRANCH:$EXPECTED_SHA" | ||
| git push origin "HEAD:refs/heads/$BRANCH" |
There was a problem hiding this comment.
If the Dependabot PR is closed and its branch is deleted while this job is building, no closed event cancels the workflow and this ordinary refspec push recreates the deleted branch. The removed exact lease rejected that case because the remote ref no longer equaled EXPECTED_SHA; as git push -h documents, --force-with-lease=<refname>:<expect> will “require old value of ref to be at this value.” Keep an atomic expected-SHA guard so a stale job cannot resurrect a deliberately deleted dependency branch.
Useful? React with 👍 / 👎.
1 participant
Closed unmerged after reviewing the actual concurrency semantics. The current exact-head checkout creates only a child commit; its explicit lease prevents concurrent deletion from recreating a stale branch. Removing the lease would weaken correctness without fixing a demonstrated history rewrite. Release publication already uses an ordinary atomic exact-tag push.