Repository navigation
refactor: remove unused wrapping and default-branch helpers (#670) - #721
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
left a comment
There was a problem hiding this comment.
Holistic review of PRs #717–#728
Reviewed 058d7e8890783ff36db255156e0ed11dc8659749 against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.
Assessment: correct, useful simplification; ready for final verification. No actionable defect found.
All wrapText references are its declaration and the removed, exclusively owned test block/import. getDefaultGitBranch has no call sites. Neither is in the supported root exports or published root declarations. Other helpers and their tests remain; retaining execSync is correct because active version-resolution code still uses it.
Removing a dead wrapping implementation and unused shell fallback is preferable to modernizing them or replacing them with new abstractions. The change does not address #631's actual target, getCurrentVersionString; that issue must be reconciled separately with today's version-selection contract. No keyword-presence/absence test is warranted.
Current-head Node 24/26, lint and both real-repository integration checks are green. #722 edits a different helper region and is compatible with this deletion.
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Removes unused
wrapText(and its exclusively owned tests) and unusedgetDefaultGitBranch, including its nested shell-command fallback. Neither has production call sites in the reviewed main source. This resolves the magic-number and nested-catch inventory without adding abstractions. Draft pending full reference scan, type check and CI. Related #670.