Skip to content

refactor: remove unused wrapping and default-branch helpers (#670) - #721

Merged
Jamie-BitFlight merged 2 commits into
mainfrom
refactor/670-remove-unused-helpers
Oct 10, 2026
Merged

Jamie-BitFlight merged 2 commits into
mainfrom
refactor/670-remove-unused-helpers

Conversation

@Jamie-BitFlight

Copy link
Copy Markdown
Contributor

Removes unused wrapText (and its exclusively owned tests) and unused getDefaultGitBranch, including its nested shell-command fallback. Neither has production call sites in the reviewed main source. This resolves the magic-number and nested-catch inventory without adding abstractions. Draft pending full reference scan, type check and CI. Related #670.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: bitflight-devops/github-action-readme-generator/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 15617c68-e59c-4e6a-8d4c-a7c308633fd5

📥 Commits

Reviewing files that changed from the base of the PR and between edb05b4 and 058d7e8.


📒 Files selected for processing (2)
  • __tests__/helpers.test.ts
  • src/helpers.ts

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 92.8% 993 / 1070
🔵 Statements 92.94% 1015 / 1092
🔵 Functions 95.59% 152 / 159
🔵 Branches 86.44% 542 / 627
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/helpers.ts 94.53% 87.17% 95.45% 94.44% 224, 254, 372-373, 391-392, 471-472, 513-514
Generated in workflow #1069 for commit 058d7e8 by the Vitest Coverage Report Action

@Jamie-BitFlight
Jamie-BitFlight marked this pull request as ready for review October 10, 2026 21:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T21:14:58.808232Z 058d7e8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Jamie-BitFlight Jamie-BitFlight left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic review of PRs #717–#728

Reviewed 058d7e8890783ff36db255156e0ed11dc8659749 against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.

Assessment: correct, useful simplification; ready for final verification. No actionable defect found.

All wrapText references are its declaration and the removed, exclusively owned test block/import. getDefaultGitBranch has no call sites. Neither is in the supported root exports or published root declarations. Other helpers and their tests remain; retaining execSync is correct because active version-resolution code still uses it.

Removing a dead wrapping implementation and unused shell fallback is preferable to modernizing them or replacing them with new abstractions. The change does not address #631's actual target, getCurrentVersionString; that issue must be reconciled separately with today's version-selection contract. No keyword-presence/absence test is warranted.

Current-head Node 24/26, lint and both real-repository integration checks are green. #722 edits a different helper region and is compatible with this deletion.

@Jamie-BitFlight
Jamie-BitFlight merged commit e907257 into main Oct 10, 2026
11 checks passed
@Jamie-BitFlight
Jamie-BitFlight deleted the refactor/670-remove-unused-helpers branch October 10, 2026 23:11
@Jamie-BitFlight

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jamie-BitFlight Jamie-BitFlight added the released This issue/pull request has been released. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant