Repository navigation
refactor: simplify Markdown table row rendering (#670) - #724
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
left a comment
Jamie-BitFlight
left a comment
There was a problem hiding this comment.
Holistic review of PRs #717–#728
Reviewed 5416007c83e4e508eb6b070e15cc3e157dbaa6ea against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.
Assessment: correct simplification for the generator's supported table inputs; ready for final verification. No blocking defect found.
I compared the actual main/head renderer functions over 606 deterministic cases: dense rectangular/ragged rows, header-only tables, an empty row where another supplies columns, whitespace, newlines/CRLF, backticks, pipes, backslash-pipe sequences, marker-like text and Unicode. Every supported nonzero-column case was byte-identical and input arrays were unchanged. Escaping order is preserved.
The two production callers, inputs and outputs, skip empty metadata and construct dense string rows with fixed headers. Empty outer arrays, zero-column tables and sparse/undefined cells do have different outcomes, but no supported caller or public export supplies them. Those observations do not establish a user-facing regression and do not justify new validation or restrictions. #727's restrictive metadata checks are not necessary for this renderer refactor.
Current-head Node 24/26, lint, build/generate-docs and both rebuilt third-party integration checks are green. This change is independent of the logger stack.
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 participant
Replace the intermediate delimiter matrix and nested index mutations with row-oriented rendering. Reuse existing escaping and padding helpers, remove the unnecessary padding assertion. Intended to preserve output bytes including trailing newlines, header emphasis, delimiters and ragged rows.
Draft pending byte-for-byte fixture comparison, all existing markdowner tests, README contract verification and CI. Related #670.