Skip to content

refactor: isolate logging group state by task instance (#670) #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jamie-BitFlight wants to merge 1 commit into from
Closed

refactor: isolate logging group state by task instance (#670) #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/logtask/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default class LogTask {
/**
* Map of ingroup settings per task name.
*/
private static ingroupSettings = new Map<string, boolean>();
private groupActive = false;
Comment thread
Jamie-BitFlight marked this conversation as resolved.

/**
* The width of the indentation for log messages.
Expand Down Expand Up @@ -169,14 +169,14 @@ export default class LogTask {
* Gets the ingroup setting for the task.
*/
get ingroup(): boolean {
return LogTask.ingroupSettings.get(this.name) ?? false;
return this.groupActive;
}

/**
* Sets the ingroup setting for this task.
*/
set ingroup(value: boolean) {
LogTask.ingroupSettings.set(this.name, value);
this.groupActive = value;
}

getMessageString(step: string, desc: string, emojiStr: string): string {
Expand Down
Loading