Repository navigation
docs: update CLI and library entrypoint guidance (#670) - #730
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
left a comment
There was a problem hiding this comment.
Reviewed b2ddfe4234ddaa512888f7a4911ed246f0d84625 against main 40c9efd1eec677f6bf024402459661741330233a.
The entry-point correction is necessary after #725: src/cli.ts supplies the CLI error boundary and emits dist/bin/index.js; src/index.ts remains the library entry with its existing import-time generation. I traced those statements to the current build configuration and entry sources. The only changed file is AGENTS.md.
One P3 documentation defect is attached inline: the two entries were joined with literal backslash-n text instead of a real line break. No implementation regression was found in this documentation-only diff. The PR description also mentions removing the errors-directory map entry, but the diff does not do that and src/errors/is-error.ts still exists; deleting ErrorType did not remove that directory.
Both Node check runs are red. The inspected Node 24 job fails vp check only on src/inputs.ts, inherited from main/#726, then skips tests, coverage, build and docs generation. This PR did not introduce that failure. The separate lint and third-party integration checks succeeded.
Correct the inline typo, incorporate the shared formatting repair, and verify the resulting head. This documentation change can remain independent of #729; there is no functional dependency between their diffs.
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Update AGENTS.md repository map after #725 introduced a separate CLI error boundary. The CLI entry source is
src/cli.tsand still emitsdist/bin/index.js;src/index.tsremains the library entry. Remove the obsoletesrc/errors/map entry following #719. No public README option or user-facing configuration documentation changes are necessary for the merged fixes. Verify markdown lint and CI.