Repository navigation
chore(lint): replace markdownlint-cli with rumdl - #741
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe repository replaces markdownlint with rumdl for Markdown linting. The change updates lint configuration, package scripts, CI output settings, cache exclusions, and repository guidance. ChangesMarkdown Linter Migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The migration updates the matching npm lockfile. The only identified lint-coverage difference concerns lines longer than 99,999 characters, and no affected file was established. No material build or user-facing risk is indicated; normal checks are sufficient. Pre-merge checks |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent checker completed for head The checker independently ran both lint commands, exercised all 18 configured rules and permitted controls, tested suppression comments and file exclusions, traced the nested npm fix command to the installed native binary, checked fixes against excluded-file hashes, observed GitHub annotations and failure exit status, and compared the production/shared lockfile entries. Known differences are recorded in the PR body: the native directory scan skips symlinks (none are active Markdown targets here), and diagnostic/fix behavior is not byte-for-byte identical. The existing repository-wide Git whitespace attribute also makes The published changed-file blob SHAs match the locally tested files, and the PR is now ready for GitHub review and CI reconciliation. |
Coverage Report
File CoverageNo changed files found. |
|
Merged as Post-merge verificationAll main-branch workflows completed successfully for that commit:
The release runner created a local build commit, but did not advance main; main remains Dependency reconciliationThe merged lockfile and installed graph remove Markdownlint, #739 now retains only the bundled npm selector-parser remediation. #740 records the removed nested YAML instance and the other remaining development-tool findings. Both issues retain the historical evidence. |
|
🎉 This PR is included in version 2.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why
The Markdown linter brings in the
smol-toml, KaTeX, and nestedjs-yamldependency branches tracked in #739 and #740. Replace it with the selectedrumdltool.Changes
markdownlint-cliwithrumdl@^0.2.79, using its npm-distributed native binary..rumdl.toml; retain the existinglint:markdownandlint:markdown:fixscripts.continue-on-errorsetting.Application sources and the production dependency graph are unchanged. Unrelated lockfile entries retain their versions and metadata.
Verification
Executed locally with Node 24.19.0:
npm run check,npm run build, and all 722 tests in 25 files passed.npm run lint:markdownpassed on all 10 current Markdown files.The native directory scan skips symlinks, unlike the old glob walker; this repository's tracked symlinks are in excluded agent directories. Diagnostic wording and available autofixes differ between tools.
Independent review found no migration defects. Codex and CodeRabbit completed without actionable findings.
GitHub verification for head
518b210bd89918454f38a5588cb93f42d8ca9473:Run rumdlstep succeeded with native GitHub output enabled.Decoded logs establish checkout of this head, or its merge with the unchanged main base.
Refs #739
Refs #740
Summary by CodeRabbit