Skip to content

fix(pre-commit): run bundled CLI directly - #747

Merged
Jamie-BitFlight merged 1 commit into
mainfrom
fix/pre-commit-bundled-cli
Oct 13, 2026
Merged

Jamie-BitFlight merged 1 commit into
mainfrom
fix/pre-commit-bundled-cli

Conversation

@Jamie-BitFlight

Copy link
Copy Markdown
Contributor

Why

The v2.1.0 hook wrapper executes the matching npm release through npx. The release smoke exposed a registry-availability window: npm accepted 2.1.0 but reported it was still being processed, and the hook received a 404 before the tarball became available.

Released repository revisions already contain the self-contained executable dist/bin/index.js, so the hook does not need the npm registry at runtime.

Changes

  • require only Node.js in the consumer environment;
  • execute the provider revision's dist/bin/index.js directly;
  • forward pre-commit args: unchanged;
  • fail clearly if a non-release revision lacks the bundled CLI.

Verification

The existing published-hook smoke test exercises this branch through real pre-commit configuration, including custom --readme arguments, first-run modification detection, and a clean idempotent second run. The repository's bundled-binary test independently verifies that dist/bin/index.js works without node_modules.

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T10:48:47.663148Z 3784733 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: bitflight-devops/github-action-readme-generator/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6a4b748d-8418-49a5-bd4e-5e5f2016bbab
📥 Commits

Reviewing files that changed from the base of the PR and between b0624fe and 3784733.

📒 Files selected for processing (1)
  • scripts/pre-commit-hook.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 94.05% 1012 / 1076
🔵 Statements 94.18% 1037 / 1101
🔵 Functions 96.95% 159 / 164
🔵 Branches 88.26% 564 / 639
File CoverageNo changed files found.
Generated in workflow #1155 for commit 3784733 by the Vitest Coverage Report Action

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 3784733987

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Jamie-BitFlight
Jamie-BitFlight merged commit 8050260 into main Oct 13, 2026
12 checks passed
@Jamie-BitFlight
Jamie-BitFlight deleted the fix/pre-commit-bundled-cli branch October 13, 2026 11:42
Jamie-BitFlight pushed a commit that referenced this pull request Oct 13, 2026
## [2.1.1](v2.1.0...v2.1.1) (2026-10-13)

### Bug Fixes

* **pre-commit:** run bundled CLI directly ([#747](#747)) ([8050260](8050260))
@Jamie-BitFlight

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jamie-BitFlight Jamie-BitFlight added the released This issue/pull request has been released. label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant