Do not auto-retry native builds before tests - #11
Draft
ofalvai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
E2E tests perform full native
xcodebuild/gradlebuilds, and those builds can fail for various reasons (this is a kind of verification, even before any E2E test case actually runs). At the moment, those failures are retried automatically, citing:This is probably no longer true, and the retry makes test runs unnecessarily long when there is a genuine failure.
Changes
Remove that retry logic completely.
Also, the old iOS handler ended in
return nullon the second failure, so a genuinely broken build resolved as success and the failure surfaced later as a confusing "app not installed" error. Now a bad xcodebuild rejects and fails the run directly.Edit: re-ran CI 4 times just to see if it's flaky, but every run was green.