-
Notifications
You must be signed in to change notification settings - Fork 19
creating qa skill based on retro feedback #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prograhamming
wants to merge
11
commits into
main
Choose a base branch
from
create-qa-check-story-skill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c2b55e7
creating qa skill based on retro feedback
prograhamming a224756
updating skill
prograhamming 8e0d322
fixing skill and merge in main
prograhamming 08a660d
testing JFrog
prograhamming 09fbaf2
fixing skill based on comments
prograhamming 570c859
AI-27 fixing issues
prograhamming 3afb40e
fixing issues
prograhamming 8b00ee6
Merge branch 'main' into create-qa-check-story-skill
prograhamming d2ad991
AI-27 fixing skill based on feedback
prograhamming 5de5238
AI-27 fixing issues based on comments
prograhamming c3700dc
AI-27 merging in main
prograhamming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,6 +116,7 @@ | |
| "pyproject", | ||
| "pytest", | ||
| "remotelink", | ||
| "reprompt", | ||
| "Rescope", | ||
| "resolutiondate", | ||
| "retarget", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β CRITICAL: Unresolved merge conflict committed to the root README β 13 of 16 plugin rows no longer render as a table
Details and fix
The merge in
c3700dcleft conflict markers in the file.pnpm run formatthen reflowed>>>>>>> maininto a markdown blockquote (> > > > > > > main), which pulled the ten rows below it into the same blockquote. That is whyLintis green β prettier sees valid markdown, so no CI check catches this.Current rendered output:
<<<<<<< HEADand=======appear as literal text on the page.bitwarden-atlassian-tools,bitwarden-code-review, andbitwarden-delivery-toolseach show twice with different versions.|-delimited text instead of table rows.Also note the HEAD side carries stale versions β
bitwarden-code-review1.13.1andbitwarden-delivery-tools3.0.0, versus1.14.0and3.1.0onmain. Resolving by keeping HEAD would silently revert both catalog entries, so the resolution needs main's values plus this PR's2.7.1forbitwarden-atlassian-tools.Suggested resolution (run
pnpm run formatafterward so prettier re-pads the column widths across the whole table):