Skip to content

Security Principles Page Is Dead Link for Security Skill - #847

Open
prograhamming wants to merge 1 commit into
mainfrom
docs/security-principles-index
Open

Security Principles Page Is Dead Link for Security Skill#847
prograhamming wants to merge 1 commit into
mainfrom
docs/security-principles-index

Conversation

@prograhamming

@prograhamming prograhamming commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

No tracking. Came up from a conversation in slack in team eng ai channel

📔 Objective

bitwarden-security-context/SKILL.md has a broken page. Fixing this to help the model have access to a security principles link within the skill, but also give a high level summary of each of the principles.

📸 Screenshots

Before:
image

After:

image image

@prograhamming
prograhamming requested review from a team as code owners August 28, 2026 16:31
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 643ea3d
Status: ✅  Deploy successful!
Preview URL: https://076bc431.contributing-docs.pages.dev
Branch Preview URL: https://docs-security-principles-ind.contributing-docs.pages.dev

View logs

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single new documentation page, docs/architecture/security/principles/index.mdx, which gives the previously page-less principles category a landing page so /architecture/security/principles resolves instead of 404ing. I verified each principle summary against 01- through 06-*.mdx and found the P01-P06 descriptions, the locked-versus-unlocked framing, and the device-compromise mapping accurate to the source pages. Relative links (../requirements.mdx, ../index.mdx#references, and the six extensionless sibling links) match the pattern already used in 03-limited-security-on-semi-compromised.mdx and 04-no-security-on-fully-compromised.mdx, and the build runs with onBrokenLinks: "throw" with a successful Cloudflare Pages deploy on this commit. The page also satisfies the newly adopted documentation standard: explicit audience line, descriptive link text, relative in-repo links, and prose wrapped to the repo's Prettier settings.

Code Review Details

No code findings.

PR Metadata Assessment

  • QUESTION: The Objective section is empty (template comment only); a sentence on why the page was needed would help future readers.

@withinfocus withinfocus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is in the individual pages though -- we just need an index page that provides links to all sub-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants