Skip to content

test(sweep): read feedback and manifest files as UTF-8 (#624) #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbean merged 2 commits into from
Sep 30, 2026
Merged

test(sweep): read feedback and manifest files as UTF-8 (#624) #766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e6471
test(sweep): read feedback and manifest files as UTF-8 (#624)
Polloinfilzato Sep 4, 2026
7be678c
test(sweep): read the three newer feedback files as UTF-8 (#624)
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/test_sweep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3932,7 +3932,7 @@ def test_sweep_happy_path(project):
dev_spec = adapter.sessions[1]
assert "Implement the deferred-work bundle" in dev_spec.prompt
intent_path = re.findall(r"`([^`]*)`", dev_spec.prompt)[0]
intent = open(intent_path).read()
intent = Path(intent_path).read_text(encoding="utf-8")
assert "fix both" in intent and "DW-2" in intent and "### DW-3" in intent


Expand Down Expand Up @@ -5045,7 +5045,7 @@ def test_triage_validation_failure_retries_with_feedback_then_escalates(project)
assert len(prompts) == 2
assert "--feedback" not in prompts[0] and "--feedback" in prompts[1]
feedback_path = prompts[1].split("--feedback ", 1)[1]
assert "not triaged: DW-1" in open(feedback_path).read()
assert "not triaged: DW-1" in Path(feedback_path).read_text(encoding="utf-8")


def test_triage_returning_a_nested_null_container_refuses_without_crashing_the_run(project):
Expand Down Expand Up @@ -5081,7 +5081,7 @@ def test_triage_returning_a_nested_null_container_refuses_without_crashing_the_r
assert len(prompts) == 2
assert "--feedback" not in prompts[0] and "--feedback" in prompts[1]
feedback_path = prompts[1].split("--feedback ", 1)[1]
assert "bundles[0] not an object: NoneType" in open(feedback_path).read()
assert "bundles[0] not an object: NoneType" in Path(feedback_path).read_text(encoding="utf-8")


def test_triage_returning_a_non_mapping_document_refuses_without_crashing_the_run(project):
Expand Down Expand Up @@ -5130,7 +5130,9 @@ def test_triage_returning_a_non_mapping_document_refuses_without_crashing_the_ru
assert len(prompts) == 2
assert "--feedback" not in prompts[0] and "--feedback" in prompts[1]
feedback_path = prompts[1].split("--feedback ", 1)[1]
assert "triage result not a JSON object: list" in open(feedback_path).read()
assert "triage result not a JSON object: list" in Path(feedback_path).read_text(
encoding="utf-8"
)
# nothing escaped `run()`: no crash record, and a refused triage classified
# nothing, so the ledger it was reading is left exactly as it was
assert _records(engine, "run-crash") == []
Expand Down Expand Up @@ -21553,7 +21555,7 @@ def test_migration_validation_failure_restores_ledger_then_escalates(project):
prompts = [s.prompt for s in adapter.sessions]
assert len(prompts) == 2
assert "--feedback" not in prompts[0] and "--feedback" in prompts[1]
feedback = open(prompts[1].split("--feedback ", 1)[1]).read()
feedback = Path(prompts[1].split("--feedback ", 1)[1]).read_text(encoding="utf-8")
assert "still parse as legacy" in feedback and "not mapped" in feedback


Expand Down Expand Up @@ -23027,7 +23029,9 @@ def non_mapping_migrate(spec):
assert len(prompts) == 2
assert "--feedback" not in prompts[0] and "--feedback" in prompts[1]
feedback_path = prompts[1].split("--feedback ", 1)[1]
assert "migration result not a JSON object: list" in open(feedback_path).read()
assert "migration result not a JSON object: list" in Path(feedback_path).read_text(
encoding="utf-8"
)
# nothing escaped `run()`, and the un-migrated ledger is left as it was
assert _records(engine, "run-crash") == []
assert project.deferred_work.read_text(encoding="utf-8") == LEGACY_LEDGER
Expand Down
Loading