Repository navigation
ci: point the weekly architecture reminder at the root ARCHITECTURE.md - #846
Conversation
The root ARCHITECTURE.md owns module boundaries and data flow, and AGENTS.md and CLAUDE.md check its age. ops-cadence.yml still measured ops/02-ARCHITECTURE.md and asked about boundary changes there. The PR template keeps sending export changes to ops/02-ARCHITECTURE.md, which holds the export table. ops-cadence.yml is disabled; ops/FOLLOWUP.md now records its broken price check (the LAST_UPDATED literal moved in #792) to fix before it runs again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: c87e4ff5-5918-476e-b982-08cbe2286f78) |
🤖 Claude reviewReviewCore change ( Minor issues
require("git log -1 --format=%ct -- ARCHITECTURE.md)" in workflow, ...)The trailing
Noted and disclosed, but this is process noise worth preventing. The test harness should have validated that
The No blocking issues. The core fix is minimal and correct; the proof is thorough. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Replies to the Claude review above:
🤖 Addressed by Claude Code |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 59a49d7f-d045-46b1-9e75-cb868f1cc403) |
🤖 Claude reviewLGTM - no blocking issues. One non-blocking note: |
|
Re the 🤖 Addressed by Claude Code |
Summary
ops-cadence.ymlnow measures the age of the rootARCHITECTURE.mdand names it in the weekly "any boundary changes?" reminder. The root file owns module boundaries and data flow (ARCHITECTURE.md:116), andAGENTS.mdandCLAUDE.mdalready check its age.ops/02-ARCHITECTURE.mdholds the table of the 52 exports fromsdk/agentguard/__init__.py, so export changes still go there.ops/FOLLOWUP.md: resolves the open question from docs: fix stale and broken agent instructions from prompt audit #842, and records a defect in the disabled workflow's price check.Goal: one architecture file per question. Scope: two lines in
ops-cadence.yml, one follow-up note. Non-goals: re-enabling the workflow, fixing its price check, changingops/02or the PR template. Done: the reminder names the root file, the checks below pass, and the proof is saved (ops/04-DEFINITION_OF_DONE.md).Related Issues
Follow-up from #842.
Proof
Saved under
proof/architecture-doc-pointers/(Windows 11, Python 3.13.2, Git Bash 5.2.37;makeis not installed, so each command ran directly).ops-cadence.yml,ghstubbed, Monday forcedarch_age=8today; at +30 days the reminder namesARCHITECTURE.mdpython scripts/sdk_preflight.pypython scripts/review_readiness_guard.pypython scripts/ci_tools_requirements_guard.pypytest sdk/tests/test_architecture.pypytest sdk/tests/test_review_readiness_guard.pypython scripts/sdk_release_guard.pypython proof/architecture-doc-pointers/verify.pyshowwork session
architecture-doc-pointers: VERIFIED, 7/7 checks green, withverify.pyas the declared acceptance check.Review Readiness
disabled_manually(last run 2026-06-11), so nothing runs until someone turns it on.Risk And Rollback
Low. When the workflow is turned on again, the reminder tracks the root file. To roll back, revert this commit.
Note: the first local run of the step did not use the
ghstub (a Windows path inPATHhid it), and the realghopened issues #844 and #845. Both are closed as not planned with a note. The saved run uses a guarded stub.Scope
Checklist
make checkpasses: not run in full. No SDK file changed, and preflight found nothing to run.make structuralpasses (9 passed)make securitypasses: not run, no SDK code changedverify.pyand the stubbed workflow-step run__init__.pyexports changed,ops/02-ARCHITECTURE.mdupdated. N/A.🤖 Generated with Claude Code
Note
Low Risk
Two-line workflow path/text change with no SDK or API impact; workflow is manually disabled until re-enabled.
Overview
Aligns the ops-cadence staleness job with the root
ARCHITECTURE.md(boundaries/data flow):arch_ageand the Monday reminder now reference that file instead ofops/02-ARCHITECTURE.md. The PR template and export table inops/02-ARCHITECTURE.mdare unchanged.ops/FOLLOWUP.mdcloses the follow-up from #842 (whether cadence should trackops/02) and documents that the workflow has been off since 2026-06-11, plus a separate defect: the price step still parses a literalLAST_UPDATEDincost.pyand will false-alarm until it readsprice_table.py.Adds
proof/architecture-doc-pointers/(verify.py, stubbed workflow-step capture, guard runs) and showwork receipts so the pointer change stays enforced.Reviewed by Cursor Bugbot for commit 1165e17. Bugbot is set up for automated code reviews on this repo. Configure here.