Skip to content

Polish MyData vault and verifier presentation flows - #57

Open
mashbean wants to merge 8 commits into
codex/711-pickup-qrfrom
codex/mydata-vault-flow
Open

Polish MyData vault and verifier presentation flows#57
mashbean wants to merge 8 commits into
codex/711-pickup-qrfrom
codex/mydata-vault-flow

Conversation

@mashbean

@mashbean mashbean commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • polish MyData document onboarding, vault continuation, card stacking, sharing, and trust/status screens
  • keep MyData titles readable in collapsed stacks and stabilize wallet interactions
  • keep one MyData Personal documents session open while several completed files are imported
  • resolve the matching pending request when an inbox filename identifies a known document
  • improve the missing-claim explanation and remove the cancelled Matters proof-helper work from the roadmap

MyData authentication boundary

MyData authorisation is single-use and the data-providing agency decides the required identity check. The app therefore does not retain or replay a Mobile Citizen Certificate assertion. It keeps the official persistent website session open only for downloading several files that are already available in Personal documents; a new data request may still require identity verification.

Verifier fix

The production verifier used to request both name and roc_birthday from every government card. Telecom cards have no birthday, so the general scenario could never present. The paired verifier deployment now requests:

  • government/general: name
  • government/age: roc_birthday
  • self-issued/general: name, birthdate
  • self-issued/age: birthdate

The stacked #56 base contains the corresponding iOS vc+moica response path for self-issued MyData credentials; this PR adds the MyData vault and UI follow-up.

Verification

  • backupTWTests: 1,568 total; 1,562 passed; 6 skipped; 0 failed
  • batch-import behaviour test covers two Personal documents downloads staying in one session and a direct item dismissing normally
  • current branch built successfully and was installed on the connected iPhone 14
  • verifier: 41 tests passed; TypeScript typecheck passed
  • production smoke test decoded all four signed request variants and confirmed their expected claim lists and formats

Stack

This PR is intentionally based on codex/711-pickup-qr / #56. GitHub therefore shows only the MyData follow-up commits here. After #56 merges, retarget this PR to main.

Remaining device validation

  • confirm two completed files can be downloaded consecutively from one Personal documents sign-in
  • verify any new MyData request that requires Mobile Citizen Certificate authentication still hands off and returns correctly

@mashbean
mashbean force-pushed the codex/mydata-vault-flow branch 2 times, most recently from dbed350 to 8ce3ea1 Compare September 1, 2026 11:47
@mashbean
mashbean force-pushed the codex/mydata-vault-flow branch from 8df1c05 to 1ebf5e1 Compare September 1, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant