Fix MATLAB MEX error handling for Octave - #204
Merged
Merged
Conversation
dellaert
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Octave mex.h includes C++ template declarations, which cannot appear inside an outer extern "C" block. Separately, generated gateways redirected std::cout to a stack-local mstream but restored it only after the exception handler. Because mexErrMsgTxt does not return, the error path left std::cout pointing at destroyed storage and Octave could segfault while displaying the exception.
This was reproduced while handling a failed GTSAM CustomFactor callback. With the stream restoration in place, the callback failure is reported as a normal interpreter error instead of SIGSEGV.
Testing