Skip to content

chore(gravity): configure rust toolchain - #690

Merged
AugustDG merged 1 commit into
masterfrom
codex/setup-gravity-rust-mise
Jun 30, 2026
Merged

chore(gravity): configure rust toolchain#690
AugustDG merged 1 commit into
masterfrom
codex/setup-gravity-rust-mise

Conversation

@AugustDG

Copy link
Copy Markdown
Contributor

Summary

  • Add Rust to the repo-level mise-compatible .tool-versions file.
  • Remove the duplicate Gravity workflow Rust setup step so CI uses the repo toolchain configuration.
  • Bump @bpinternal/gravity to 0.1.1.

Validation

  • git diff --check
  • pnpm check in gravity
  • pnpm test in gravity
  • pnpm build in gravity

@AugustDG
AugustDG requested a review from a team as a code owner June 30, 2026 19:30
@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown

Greptile Summary

This PR configures a Rust toolchain entry in the repo-level .tool-versions file for local mise/asdf users, removes the explicit dtolnay/rust-toolchain@stable CI step from the Gravity workflow, and bumps @bpinternal/gravity to 0.1.1.

  • .tool-versions gains rust stable for local developer toolchain management via mise/asdf.
  • The Gravity CI workflow drops the dtolnay/rust-toolchain@stable step (which also installed the wasm32-unknown-unknown WASM target) but does not add a step to install tools from .tool-versions; no other workflow in the repo uses mise/asdf in CI.
  • gravity/package.json is bumped from 0.1.0 to 0.1.1.

Confidence Score: 4/5

The change is mostly safe — the ubuntu-latest runner ships Rust stable and wasm-pack auto-installs the WASM target — but CI is no longer explicitly pinning the Rust toolchain and the .tool-versions file has no effect there.

The workflow removes the only explicit Rust setup step without adding a mechanism to read .tool-versions in CI. The build will likely continue to pass today because the runner image bundles Rust and wasm-pack can add the WASM target on its own, but the Rust version in CI is now implicit and unpinned, creating a quiet divergence between local and CI environments that could surface unexpectedly.

.github/workflows/gravity.yml deserves a second look — a jdx/mise-action step (or restoring dtolnay/rust-toolchain) should be added so CI actually honours the toolchain file.

Important Files Changed

Filename Overview
.github/workflows/gravity.yml Removes the explicit dtolnay/rust-toolchain@stable step (including the wasm32-unknown-unknown target) without adding a step to consume .tool-versions; CI now relies on the runner's pre-installed Rust with no version pin.
.tool-versions Adds rust stable for local mise/asdf toolchain management; correct addition for developer environments but has no effect on CI without a corresponding workflow step.
gravity/package.json Bumps version from 0.1.0 to 0.1.1; straightforward patch-level version bump with no other changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[gravity.yml trigger] --> B[checkout]
    B --> C[pnpm setup]
    C --> D[node setup]
    D --> E{Rust setup}
    E -->|Before PR| F[dtolnay rust-toolchain stable\nwasm32-unknown-unknown target installed]
    E -->|After PR| G[No step - relies on\nubuntu-latest pre-installed Rust]
    F --> H[pnpm install and build]
    G --> H
    H --> I[wasm-pack build]
    I -->|Before PR| J[Target ready]
    I -->|After PR| K[wasm-pack auto-installs target implicitly]

    subgraph dotfile [.tool-versions]
      L[rust stable]
    end
    dotfile -.->|never read by CI - no mise step| A
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[gravity.yml trigger] --> B[checkout]
    B --> C[pnpm setup]
    C --> D[node setup]
    D --> E{Rust setup}
    E -->|Before PR| F[dtolnay rust-toolchain stable\nwasm32-unknown-unknown target installed]
    E -->|After PR| G[No step - relies on\nubuntu-latest pre-installed Rust]
    F --> H[pnpm install and build]
    G --> H
    H --> I[wasm-pack build]
    I -->|Before PR| J[Target ready]
    I -->|After PR| K[wasm-pack auto-installs target implicitly]

    subgraph dotfile [.tool-versions]
      L[rust stable]
    end
    dotfile -.->|never read by CI - no mise step| A
Loading

Reviews (1): Last reviewed commit: "chore(gravity): configure rust toolchain" | Re-trigger Greptile

Comment thread .github/workflows/gravity.yml
@AugustDG
AugustDG merged commit 0801fea into master Jun 30, 2026
2 checks passed
@AugustDG
AugustDG deleted the codex/setup-gravity-rust-mise branch June 30, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants