chore(gravity): configure rust toolchain - #690
Conversation
Greptile SummaryThis PR configures a Rust toolchain entry in the repo-level
Confidence Score: 4/5The change is mostly safe — the ubuntu-latest runner ships Rust stable and wasm-pack auto-installs the WASM target — but CI is no longer explicitly pinning the Rust toolchain and the .tool-versions file has no effect there. The workflow removes the only explicit Rust setup step without adding a mechanism to read .tool-versions in CI. The build will likely continue to pass today because the runner image bundles Rust and wasm-pack can add the WASM target on its own, but the Rust version in CI is now implicit and unpinned, creating a quiet divergence between local and CI environments that could surface unexpectedly. .github/workflows/gravity.yml deserves a second look — a jdx/mise-action step (or restoring dtolnay/rust-toolchain) should be added so CI actually honours the toolchain file. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[gravity.yml trigger] --> B[checkout]
B --> C[pnpm setup]
C --> D[node setup]
D --> E{Rust setup}
E -->|Before PR| F[dtolnay rust-toolchain stable\nwasm32-unknown-unknown target installed]
E -->|After PR| G[No step - relies on\nubuntu-latest pre-installed Rust]
F --> H[pnpm install and build]
G --> H
H --> I[wasm-pack build]
I -->|Before PR| J[Target ready]
I -->|After PR| K[wasm-pack auto-installs target implicitly]
subgraph dotfile [.tool-versions]
L[rust stable]
end
dotfile -.->|never read by CI - no mise step| A
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[gravity.yml trigger] --> B[checkout]
B --> C[pnpm setup]
C --> D[node setup]
D --> E{Rust setup}
E -->|Before PR| F[dtolnay rust-toolchain stable\nwasm32-unknown-unknown target installed]
E -->|After PR| G[No step - relies on\nubuntu-latest pre-installed Rust]
F --> H[pnpm install and build]
G --> H
H --> I[wasm-pack build]
I -->|Before PR| J[Target ready]
I -->|After PR| K[wasm-pack auto-installs target implicitly]
subgraph dotfile [.tool-versions]
L[rust stable]
end
dotfile -.->|never read by CI - no mise step| A
Reviews (1): Last reviewed commit: "chore(gravity): configure rust toolchain" | Re-trigger Greptile |
Summary
.tool-versionsfile.@bpinternal/gravityto0.1.1.Validation
git diff --checkpnpm checkingravitypnpm testingravitypnpm buildingravity