Label /var/lib/systemd/pstore as secret_t, include in logdog - #1028
Merged
Conversation
systemd-pstore copies kernel crash data (dmesg, EFI variables) from /sys/fs/pstore to /var/lib/systemd/pstore early in boot. Add a glob entry so logdog includes this data in support bundles. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Label the pstore directory with secret_t to match the treatment of /var/log/kdump. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
/var/lib/systemd/pstore as secret_t, include in logdog
ginglis13
marked this pull request as ready for review
September 2, 2026 00:43
vigh-m
approved these changes
Sep 2, 2026
piyush-jena
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1027
Description of changes:
Label
/var/lib/systemd/pstoreassecret_tand include this content inlogdogbundleTesting done:
/var/lib/systemd/pstoresysrq-triggersystemd-pstorearchived crash datalogdogand verify pstore data is captured in support bundleValidate SELinux label:
Triggered panic via:
Post-crash:
All archived files inherit
secret_tlabel.Instance rebooted successfully after crash. After reboot,
systemd-pstore.serviceran successfully:Journal output confirmed 16 EFI pstore dmesg chunks were moved from
/sys/fs/pstore/to/var/lib/systemd/pstore/1788309035/001/. Additionally, a reassembleddmesg.txtwas created containing the complete kernel log from boot through panic.The panic trace in
dmesg.txtclearly shows:Logdog output confirmed the new glob was executed:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.