Fix/python remote eval normalize list score dicts#595
Open
Everett Smith (evrtt) wants to merge 2 commits into
Open
Fix/python remote eval normalize list score dicts#595Everett Smith (evrtt) wants to merge 2 commits into
Everett Smith (evrtt) wants to merge 2 commits into
Conversation
Member
|
does this issue effect the other sdks? |
Author
|
Abhijeet Prasad (@AbhiPrasad) yeah Go and Ruby both similarly fail with a list of scores currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Valid multi-score remote scorer results from remote eval scorers are rejected. Remote eval scorers can return
list[Score], but that result crosses an HTTP/JSON boundary and the caller receiveslist[dict]rather than realScoreobjects.await_or_run_scorernormalizes a single score dict withScore.from_dict(), but is missing normalization forlist[dict]responses.Changes
Score.from_dict().Testing
Added
test_run_evaluator_normalizes_list_of_dict_scores{"name": "per_result", "score": 1.0}"name": "summary_only", "score": 1.0}run_evaluator(...)Ran the focused core regression test
Ran a local smoke test where a scorer returns multiple score dicts, confirming the eval completes and emits both expected scores.