Skip to content

fix(openai): allowlist metadata pass-through, drop eager response serialization #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 3 commits into from
Jul 21, 2026
+190 −66
Merged

fix(openai): allowlist metadata pass-through, drop eager response serialization #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c092e6d
fix(openai): allowlist metadata pass-through, drop eager response ser…
starfolkbot Jul 21, 2026
0844212
Drop _get_attr helper and redundant None check in _filter_metadata
starfolkbot Jul 21, 2026
3e5412c
Serialize text_format the same way as response_format
starfolkbot Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions py/src/braintrust/integrations/openai/test_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ def test_openai_chat_stream_helper_sync(memory_logger):
metrics = span["metrics"]
assert_metrics_are_valid(metrics, start, end)
assert span["metadata"]["stream"] == True
assert span["metadata"]["extra_headers"]["X-Stainless-Helper-Method"] == "chat.completions.stream"
assert "extra_headers" not in span["metadata"]
assert TEST_MODEL in span["metadata"]["model"]
assert span["metadata"]["provider"] == "openai"
assert TEST_PROMPT in str(span["input"])
Expand Down Expand Up @@ -1180,7 +1180,7 @@ async def test_openai_chat_stream_helper_async(memory_logger):
metrics = span["metrics"]
assert_metrics_are_valid(metrics, start, end)
assert span["metadata"]["stream"] == True
assert span["metadata"]["extra_headers"]["X-Stainless-Helper-Method"] == "chat.completions.stream"
assert "extra_headers" not in span["metadata"]
assert TEST_MODEL in span["metadata"]["model"]
assert span["metadata"]["provider"] == "openai"
assert TEST_PROMPT in str(span["input"])
Expand Down Expand Up @@ -2751,7 +2751,7 @@ def test_setup_stream_helper_creates_spans(self, memory_logger):
span = spans[0]
assert_metrics_are_valid(span["metrics"], start, end)
assert span["metadata"]["stream"] == True
assert span["metadata"]["extra_headers"]["X-Stainless-Helper-Method"] == "chat.completions.stream"
assert "extra_headers" not in span["metadata"]
assert span["metadata"]["provider"] == "openai"
assert TEST_MODEL in span["metadata"]["model"]
assert TEST_PROMPT in str(span["input"])
Expand Down
Loading