Update anthropic provider types#359
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9fbe2190e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| pub name: String, | ||
| /// How this tool's result blocks appear in the API response when the result was consumed by a completed code_execution call in the same turn. 'full' returns the complete content (default). 'excluded' drops the nested server_tool_use and result block pair entirely. Results from direct calls, or from code_execution calls that paused before completing, are always returned in full so they can be sent back on the next turn. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub response_inclusion: Option<String>, |
There was a problem hiding this comment.
When callers construct or deserialize the new 20260318 web-fetch/web-search tool variants with response_inclusion, this accepts any string and will serialize invalid values that Anthropic rejects; the updated schema only allows full or excluded, and this commit already emits a ResponseInclusion enum for that set. Please wire this field, and the matching WebSearchTool20260318 field, to Option<ResponseInclusion> in the generator instead of Option<String> so invalid requests fail at the typed boundary.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I dunno how big of a deal this is
1 participant
Automated update of Lingua provider types.
Provider:
anthropicFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh anthropic: failure./pipelines/generate-provider-types.sh anthropic: successmake generate-types: successmake generate-types: successcargo fmt --all: successcargo build --all-features: successcargo clippy --all-targets --all-features -- -D warnings: successmake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: successThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.