Normalize component names & update stories - #11
Open
adamchaboryk wants to merge 2 commits into
Open
Conversation
- Sanitize and validate component names in plopfile: input is normalized to kebab-case, validated with a stricter /^[a-z0-9-]+$/ pattern, and data.tagName is derived from the sanitized name (with prefix if present). For example, when using `npm run new`, buttonGroup would be normalized to button-group. - Update story template title to use `dashToTitle` for nicer Storybook titles, and to prevent a bug where created files would not be nested in the component's folder. - Add missing 'control-part' default arg to src/components/button/button.stories.ts.
This prevents build issues when using web component names other than `my-`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitize and validate component names in plopfile: input is normalized to kebab-case, validated with a stricter /^[a-z0-9-]+$/ pattern, and data.tagName is derived from the sanitized name (with prefix if present). For example, when using
npm run new, buttonGroup would be normalized to button-group.Update story template title to use
dashToTitlefor nicer Storybook titles, and to prevent a bug where created files would not be nested in the component's folder.Add missing 'control-part' default arg to
src/components/button/button.stories.ts.