Repository navigation
chore(release): take the postflight tap gate from the template - #175
Open
brettdavies wants to merge 1 commit into
Open
brettdavies wants to merge 1 commit into
brettdavies wants to merge 1 commit into
Conversation
`scripts/release/postflight.sh` is the `github-repo-setup` template's copy again. Its `tap` gate finds the tap's publish run under the name `Publish formula` or `Publish bottles` and reports it under the name it has, and its pass line says the formula bump was pushed. The tap names that workflow `Publish formula` once it stops bottling a formula that installs prebuilt archives. With the gate matching one name, a finished publish would read as "no run since release.yml started".
2 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/release/postflight.shis thegithub-repo-setuptemplate's copy, byte for byte. Itstapgate finds the tap's publish run under the namePublish formulaorPublish bottles, reports the run under the name it has, and says in its pass line that the formula bump was pushed to the tap'smain.The tap names the workflow
Publish formulaonce it lands a prebuilt-archive formula without a bottle. With the gate matchingPublish bottlesalone, a finished publish would read as "no run since release.yml started".Changelog
Type of Change
feat: New feature (non-breaking change which adds functionality)fix: Bug fix (non-breaking change which fixes an issue)refactor: Code refactoring (no functional changes)perf: Performance improvementdocs: Documentation updatetest: Adding or updating testschore: Maintenance tasks (dependencies, config, etc.)ci: CI/CD configuration changesstyle: Code style/formatting changesbuild: Build system changesBREAKING CHANGE: Breaking API change (requires major version bump)Related Issues/Stories
mainbefore that one reaches the tap'smain.Testing
Test Summary:
scripts/release/postflight.sh --tag v0.6.0 tapagainst the tap's real run history: 2 passed, 0 failed, 0 skipped, with the publish run found under the namePublish bottles.Files Modified
Modified:
scripts/release/postflight.sh: the template's copy.Created:
Renamed:
Deleted: