Skip to content

feat(tests): check the editing tools automatically - #198

Open
DonIsmaelito wants to merge 1 commit into
browser-use:mainfrom
DonIsmaelito:submit/testing
Open

DonIsmaelito wants to merge 1 commit into
browser-use:mainfrom
DonIsmaelito:submit/testing

Conversation

@DonIsmaelito

@DonIsmaelito DonIsmaelito commented Sep 28, 2026 •

Copy link
Copy Markdown

Why

The existing editing tests should run automatically when a pull request changes the project. This is the general editing portion of item 23 from the core PR plan.

Changes

  • Add .github/workflows/tests.yml for pull requests, pushes to main and manual runs.
  • Run the Python tests on Python 3.10 and 3.12 with FFmpeg and the core package installed.
  • Give the workflow read-only repository access, a 15-minute job limit and cancellation of superseded runs.

Validation: all 26 existing tests pass locally on Python 3.10 with pytest 8.3.5 and on Python 3.12 (including 15 subtests). Workflow YAML parses successfully and whitespace checks pass. GitHub-hosted execution is still to be verified.

Limits

Based directly on main with no dependency on another open PR. This runs the existing suite; it does not add full video export coverage. Browser, animation and generation checks from the original item 23 remain deferred until their tools land. It uses current package dependencies because main does not yet include the proposed locked environment.


Summary by cubic

Adds a GitHub Actions workflow that runs the editing tests automatically on pull requests, pushes to main, and manual runs. The suite executes on a Python 3.10 and 3.12 matrix with FFmpeg and the core package installed via pytest 8.3.5.

The workflow uses read-only repository permissions, a 15-minute job limit, and cancels superseded runs for the same branch. All 26 existing tests pass locally on both Python versions; GitHub-hosted execution is still to be verified.

Written for commit 2472874. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/tests.yml">

<violation number="1" location=".github/workflows/tests.yml:30">
P3: None of the 26 tests call the real ffmpeg/ffprobe — test_render_fps.py and test_render_orientation.py mock render.subprocess.run for every call, and test_render_captions.py is pure string logic — so the apt-get install ffmpeg step is currently unused and only adds CI time plus an untested failure surface. Drop it now, or keep it deliberately only if the item-23 video-export tests land soon.</violation>
</file>

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Fix all with cubic | Re-trigger cubic

- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
- name: Install FFmpeg

@cubic-dev-ai cubic-dev-ai Bot Sep 28, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: None of the 26 tests call the real ffmpeg/ffprobe — test_render_fps.py and test_render_orientation.py mock render.subprocess.run for every call, and test_render_captions.py is pure string logic — so the apt-get install ffmpeg step is currently unused and only adds CI time plus an untested failure surface. Drop it now, or keep it deliberately only if the item-23 video-export tests land soon.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/tests.yml, line 30:

<comment>None of the 26 tests call the real ffmpeg/ffprobe — test_render_fps.py and test_render_orientation.py mock render.subprocess.run for every call, and test_render_captions.py is pure string logic — so the apt-get install ffmpeg step is currently unused and only adds CI time plus an untested failure surface. Drop it now, or keep it deliberately only if the item-23 video-export tests land soon.</comment>

<file context>
@@ -0,0 +1,35 @@
+      - uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python }}
+      - name: Install FFmpeg
+        run: sudo apt-get update && sudo apt-get install -y ffmpeg
+      - name: Install editing tools and test runner
</file context>
Fix with cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant