Skip to content

fix(ack): preserve lazy discriminated codec outputs - #245

Merged
leoafarias merged 1 commit into
fix/2.0-alias-capture-namesfrom
fix/2.0-lazy-codec-outputs
Oct 27, 2026
Merged

leoafarias merged 1 commit into
fix/2.0-alias-capture-namesfrom
fix/2.0-lazy-codec-outputs

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Fix discriminated map codecs that parse successfully but cannot encode their
    result when their strict output schema is lazy.
  • Apply the existing discriminator adaptation when the lazy target resolves,
    preserving its generic types, recursion limits and callbacks. Permissive
    intermediate outputs and original schemas remain unchanged.

Follow-up to #243, stacked above #244. No public API or generator changes.

Validation

  • 3,254 tests passed in full CI, including 742 generator tests;
    four credential-dependent Firebase tests remain skipped.
  • 52 focused Chrome cases passed, including the regression and lazy controls.
  • Strict analysis, formatting and release preparation verification passed;
    all five publish dry runs reported zero warnings.
  • All seven CI/preflight checks passed, including minimum SDKs, API compatibility
    and deterministic generation.

@leoafarias
leoafarias added this pull request to stack #238 October 27, 2026 01:58
@leoafarias
leoafarias marked this pull request as ready for review October 27, 2026 02:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T02:13:47.714600Z 8340d44 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias merged commit e0575c6 into release/2.0 Oct 27, 2026
7 checks passed
@leoafarias
leoafarias deleted the fix/2.0-lazy-codec-outputs branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant