Repository navigation
Release 0.6.1-dev.1: move to Ack 2.0.0-alpha.1 - #72
kauandotnet wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 943f151398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| part 'document.ack.dart'; | ||
| part 'document.ack.g.dart'; | ||
| part 'document.g.dart'; |
There was a problem hiding this comment.
The CI workflow in .github/workflows/test.yml:47–48 still runs tool/ci/check_generated.dart, whose _generatedPaths lists all six deleted .ack.dart/.ack.g.dart files. Its initial tracking check therefore exits with code 1 before regeneration, so this migration prevents CI from reaching formatting, analysis, or tests. Update that list to the three new .g.dart paths so the check both passes and continues verifying the generated output.
Useful? React with 👍 / 👎.
| @@ -1,3 +1,13 @@ | |||
| ## Unreleased | |||
There was a problem hiding this comment.
Adding this heading makes the existing the version is declared once and mirrored everywhere test in test/ci/gate_test.dart fail: it explicitly requires CHANGELOG.md to start with ## ${pubspec['version']}\n, currently ## 0.5.1\n. Keep the first heading consistent with the package version, or update the release convention and its test together rather than introducing an unsupported Unreleased section.
Useful? React with 👍 / 👎.
943f151 to
2fe121d
Compare
kauandotnet
changed the title
Depend on ack ^2.0.0-alpha.1 and generate with ack_generator 2.0.0-alpha.1, which needs analyzer 13. ack_annotations is removed: @AckModel() and @AckInfer() become @Schemable() from package:ack/ack.dart, and each annotated library declares one generated .g.dart part instead of the .ack.dart and .ack.g.dart pair. build.yaml enables the single ack_generator builder for the same three libraries, and tool/ci/check_generated.dart lists the new parts. The MCP tools' input schemas are the same except that codec fields (the concept IDs) no longer carry "x-transformed": true, which Ack 2 no longer emits. A package that depends on a prerelease must be one, or pub publish fails, so this is 0.6.1-dev.1, and the gate test accepts a prerelease suffix on the version.
2fe121d to
4d70d14
Compare
kauandotnet
changed the title
Releases 0.6.1-dev.1 on top of 0.6.0, moving okf to Ack 2.
ack ^2.0.0-alpha.1, generated withack_generator2.0.0-alpha.1 (which needs analyzer 13).ack_annotationsis removed.@AckModel()and@AckInfer()become@Schemable()frompackage:ack/ack.dart..g.dartpart instead of the.ack.dart/.ack.g.dartpair.build.yamlenables the singleack_generatorbuilder, andtool/ci/check_generated.dartlists the new parts."x-transformed": true, which Ack 2 doesn't emit.dart pub publishfails. So this is0.6.1-dev.1(pubspec,version.dart, README action tag, CHANGELOG), and the gate test accepts a prerelease suffix on the version.Still needed before tagging:
.github/workflows/release.yml's tag check (^v[0-9]+\.[0-9]+\.[0-9]+$) must also accept the suffix, for example(-[0-9A-Za-z.]+)?. Otherwise the release job refusesv0.6.1-dev.1. That edit is added separately, because this push could not change workflow files.Stargate and Wayfinder (btwld/wayfinder#159) need this release.