Repository navigation
test(naked_ui): run the test suite on the web - #322
Open
leoafarias wants to merge 1 commit into
Open
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
Move flutter_test_config.dart into test/ so `flutter test --platform chrome` can compile the suite; at the package root the web compiler cannot resolve it. Fix the two web-only failures: - integration_tests_test.dart launches a child process through dart:io, so mark it @teston('vm'). - Split the radio space and enter test. On the web Enter maps to ButtonActivateIntent, which RawRadio does not handle, so the enter half is skipped there.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
packages/naked_ui/flutter_test_config.dartsat at the package root, outsidetest/. The web test compiler cannot resolve it there, soflutter test --platform chromefailed to compile every naked_ui test file, and the existingskip: kIsWebmarkers were unreachable. This moves it intotest/and fixes the two web-only failures that surfaced.flutter_test_config.darttopackages/naked_ui/test/. The nested config intest/semantics/update_tree/still applies to its directory.integration_tests_test.dart@TestOn('vm'): it launchesflutter testin a child process throughdart:io.ButtonActivateIntent, whichRawRadiodoes not handle, as with a native radio; the Enter test is skipped there and the Space test runs on both platforms.Test-only change; no library code and no CHANGELOG entry. CI still runs the VM suite only.
Validation
flutter testinpackages/naked_ui: 952 passed, 3 skipped (opt-in integration launchers).flutter test --platform chromeinpackages/naked_ui: 949 passed, 3 skipped (kIsWeb). Before this change the suite did not compile on Chrome (Undefined name 'testExecutable').dart analyze(no new issues), rootdart formatcheck,melos run ci:checks: passed.Related Issues
Follow-up from the review of #317.
Checklist
///).Breaking Change