Repository navigation
fix(remix,registry): stop RemixSidebar rebuilding on unrelated MediaQuery changes - #323
Open
leoafarias wants to merge 1 commit into
Open
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
…uery changes RemixSidebar read MediaQuery.maybeOf(context)?.disableAnimations, which subscribes the sidebar to every MediaQuery field, so it rebuilt on each keyboard inset frame. Read only disableAnimations through MediaQuery.maybeDisableAnimationsOf. The Agent loading glyph read the same field the same way. Its preset source, registry templates, and installed dashboard and playground copies take the same one-line change. The Vanilla and Fortal SidebarLayout reads stay: MediaQuery.removePadding in the same widget subscribes it to the whole MediaQuery regardless.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RemixSidebarreadMediaQuery.maybeOf(context)?.disableAnimations, which subscribes it to everyMediaQueryfield, so it rebuilt on each keyboard-inset frame. It now reads onlydisableAnimationsthroughMediaQuery.maybeDisableAnimationsOf; the value and the no-MediaQueryfallback (false) are unchanged.The Agent loading glyph in the presets had the same read. Its preset source, the Vanilla and Fortal registry templates, and the installed dashboard and playground copies take the same one-line change. The Vanilla and Fortal
SidebarLayoutreads are left alone:MediaQuery.removePaddingin the same widget subscribes it to the wholeMediaQueryregardless, so narrowing those reads would change nothing (probed: one layout rebuild on aviewInsetschange before and after).Overlap: the reduced-motion PR (
fix/remix-reduced-motion) replaces the same sidebar lines with itsRemixReducedMotionhelper; whichever merges second keeps that version.Validation
debugOnRebuildDirtyWidget): aviewInsetschange rebuilds neither the sidebar nor the loading glyph; adisableAnimationschange rebuilds each once and takes effect (collapse settles, glyph stops). Both fail on the old read (Expected: 0, Actual: 1).packages/remixsuite (2832) andregistry_sourcesuite (1391): passed.dart analyze(remix, registry_source), rootdart formatcheck,melos run ci:checks,open-code:registry:build(no drift),open-code:apps:check: passed.Related Issues
Follow-up from the review of #319.
Checklist
///).Breaking Change