Repository navigation
fix(remix_cli): enforce registry ownership across installs - #333
Open
leoafarias wants to merge 3 commits into
Open
leoafarias wants to merge 3 commits into
leoafarias wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate installs could accept another registry's existing same-target recipe and replace it with
--overwrite, although a combined request rejected the collision. Reserve authored and generated targets in committedremix.ownership.jsonand check the complete request before dependency processes or source writes. Owners retain identity across pin changes and namespace aliases; disjoint additive registries and local edits remain supported.Unknown legacy targets now fail predictably. After verifying provenance, consumers can explicitly name existing items and dependencies with
--adopt, preview with--adopt --diff/--dry-run, and record ownership without replacing authored edits. Adoption cannot replace a known owner. Document the migration and the requirement to use the upgraded CLI consistently; publishing this behavior requires a new CLI release. Project/catalog schemas and runtime versions are unchanged.Validation on Flutter 3.44.0 / Dart 3.12.0:
melos run ci:checkspass.dart test --concurrency 2 --timeout 2m).CI on final head
238555ca73911e8a3c10b765ea4067f8889e498a: 5 checks passed, 7 running, 3 queued; no failures observed. Full CI is pending.Scope is registry installer ownership only. No slider, icon, runtime, version-floor, or #317–#320 changes; no merge or publication.