Repository navigation
Superseded: interim syntax_darts rename (see new PR) - #13
leoafarias wants to merge 2 commits into
Conversation
The name syntax is blocked on pub.dev (moderated tombstone). Point syntax_flutter and syntax_noir at syntax_core ^0.0.1 and update imports.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
leoafarias
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fbc9d49b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import 'package:syntax_core/langs/all.dart'; | ||
| import 'package:syntax_core/themes/all.dart'; |
There was a problem hiding this comment.
The Flutter example still declares syntax: ^0.0.1 in its pubspec.yaml and overrides it to ../../syntax in pubspec_overrides.yaml, but this commit removes that directory. Dependency resolution for the example therefore fails before it can run or build; both the check and minimum-sdk CI jobs resolve this example first. Rename the dependency and override to syntax_core and point the override at ../../syntax_core.
Useful? React with 👍 / 👎.
| sdk: ^3.9.0 | ||
| workspace: | ||
| - packages/syntax | ||
| - packages/syntax_core |
There was a problem hiding this comment.
The package directory is renamed here, but .github/workflows/ci.yml still uses packages/syntax for the check job's formatting input, analysis working directory, and VM/Chrome test working directories, plus the minimum-sdk job's core test working directory. Even after the example dependency issue is fixed, those working directories do not exist in this checkout, so the core analysis and tests cannot run. Update all of these workflow paths alongside the workspace entry.
Useful? React with 👍 / 👎.
| path.join(dir, file), | ||
| header(meta.source, meta.license) + | ||
| `import 'package:syntax/syntax.dart' show Language;\n\n` + | ||
| `import 'package:syntax_core/syntax.dart' show Language;\n\n` + |
There was a problem hiding this comment.
The generated imports now reference syntax_core, but generate.mjs still initializes pkg with path.join(here, '..', 'packages', 'syntax'). Regeneration consequently recreates the old directory instead of updating the bundled files, while the changed CI check inspects only packages/syntax_core and misses those outputs. samples.mjs and golden.mjs likewise retain the old fixture root, so fixture regeneration no longer updates the conformance suite's inputs. Update all three tools' filesystem roots to the renamed package.
Useful? React with 👍 / 👎.
leoafarias
changed the title
Closed in favor of #14 from
rename/syntax-to-syntax-dartsthat keepssyntax_coreand adds the OIDCpublish.ymlworkflow.Do not merge this branch / do not continue the
syntax_dartsrename.