[harmony] Bug 1983391: Add a donation banner to the home page#156
Open
justdave wants to merge 1 commit into
Open
[harmony] Bug 1983391: Add a donation banner to the home page#156justdave wants to merge 1 commit into
justdave wants to merge 1 commit into
Conversation
Contributor
|
No strong feeling if we keep the current list of options but it might be better to have less. For example,
Feel free to file a follow-up bug to explore this option if you consider it low priority for the next release ;) |
dannycolin
reviewed
Jul 2, 2026
Comment on lines
+1102
to
+1104
| border: 1px solid rgb(var(--accent-color-green-1)); | ||
| border-radius: 5px; | ||
| background: rgb(var(--accent-color-green-1)); |
Contributor
There was a problem hiding this comment.
In dark mode, the contrast ratio is too low. We have two options:
- Use
--accent-color-lightgreen-1for the border and background color - Use
--accent-color-green-1withcolor: #000 !important
I, personally, find option 1 more aesthitically more pleasing.
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><label for="donate_banner_reminder_date">Date:</label></td> |
Contributor
dannycolin
requested changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
Adds a donation banner to the front page, per the specification in Bug 1983391 comment 3
Light mode:

Dark mode:

The "call to action" message at the top is randomly picked from the following list:
I'm open to suggestion for messaging in there.
It could use a real graphic on the left, too. Buggie holding a wad of cash? @hellcp
The administrative params screen linked to in the bottom of that banner:

The end-user preferences screen:

Additional info
Test Plan