Chore: Refresh and cleanups - #10
Merged
Merged
Conversation
…able edition and resolver, clarify formatting + linting rules
…r type
BREAKING: `LineEnding::{CR,LF,CRLF}` are now `{Cr,Lf,Crlf}`
BREAKING: `FromStr::Err` is now `ParseLineEndingError`, not `Box<dyn Error>`
derive `Copy` on `LineEnding`
…elf in builders BREAKING: types are now `NodeJsRelInfo`, `NodeJsOs`, `NodeJsArch`, `NodeJsPkgExt`, `NodeJsRelInfoError` BREAKING: variants are now UpperCamelCase - e.g. `AIX` -> `Aix`, `PPC64LE` -> `Ppc64le` BREAKING: builder methods consume and return `Self`, so `to_owned()` is gone BREAKING: `fetch()` takes `self` and returns the populated value BREAKING: os/arch/ext/error enums are `#[non_exhaustive]` BREAKING: error messages drop the `Error: ` prefix and are lowercased add `NodeJsOs::SunOs` and `NodeJsArch::Armv6l` for older Node.js releases derive `Copy` on the os/arch/ext enums return an error instead of panicking on a malformed checksum line target Node.js v24.19.0 in integration tests and doc examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revives and updates codebase: Updates minimum supported rust version (MSRV) to v1.86, improves local development tooling, clarifies licensing (no practical change), tune CI, and clean up some minor code issues.
How to Test
cargo xtask --helpcargo xtask changelogcargo xtask coverage --opencargo xtask audit(docs)cargo xtask semver(docs)semver requires new major versionis returned w/ supporting detailOutcome
All commands should work as expected, new docs are clear and helpful, and code changes make sense
Related / Discussions
N/A
Completeness
cargo xtask doc)main)