Skip to content

Linker::instantiate_pre could avoid mutating a Store #5675

Description

@abrown

In #5484, it would have been ideal to check if an instance was "instantiatable" by a Linker much sooner than when we currently check it (at startup instead of when a thread is spawned). Because a Store is not available until the thread is spawned and Linker::instantiate_pre requires a mutable Store, we cannot do this check sooner. If Linker::instantiate_pre were refactored to be called without a Store or if some other method were available to "check that all the imports can be satisfied," then the check in wasi-threads could be moved up and this issue closed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions